Fix handling of top-level exceptions #5560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5564
Description
Errors that were caught as BaseExceptions in the main function were not displaying or storing the stack trace because it was flagged as debug level and also flagged as not to be written to the file. I have removed the "NoFile" flag from the events that handle top level exceptions and left it only for integration tests and "clean" command events.
A different pr will be used to address catching exception in threads.
Checklist
changie new
to create a changelog entry